From 565a91e235c9c0f03ab535fcde79bb0c4de8f934 Mon Sep 17 00:00:00 2001 From: Nathanial Lubitz Date: Mon, 29 Jun 2026 16:58:52 +1000 Subject: [PATCH] update validation --- cmd/validate.go | 5 ++--- readme.md | 12 +++++++----- 2 files changed, 9 insertions(+), 8 deletions(-) diff --git a/cmd/validate.go b/cmd/validate.go index 449b9fd..a3af536 100644 --- a/cmd/validate.go +++ b/cmd/validate.go @@ -141,9 +141,8 @@ type requiredSecret struct { // kforge.yml requires, based on what's enabled. func buildRequiredSecrets(cfg *config.KforgeConfig) []requiredSecret { secrets := []requiredSecret{ - // Always required — org level - {Name: "DOCKER_USERNAME", Location: "Gitea org secret", Required: true}, - {Name: "DOCKER_PASSWORD", Location: "Gitea org secret", Required: true}, + // kforge only needs these — DOCKER_USERNAME/PASSWORD are used by + // docker/login-action and docker/build-push-action, not by kforge itself. {Name: "KFORGE_NODE_IP", Location: "Gitea org secret", Description: "Node IP written as the external-dns annotation target"}, // Always required — repo level diff --git a/readme.md b/readme.md index c15cb45..8e1a11e 100644 --- a/readme.md +++ b/readme.md @@ -637,11 +637,13 @@ kforge works with three categories of secrets, each living in the right place fo Set once at the organisation level; available to every repo automatically. -| Secret | Purpose | -|---|---| -| `DOCKER_USERNAME` | Registry authentication | -| `DOCKER_PASSWORD` | Registry authentication | -| `KFORGE_NODE_IP` | Cluster node IP — written as the external-dns target annotation | +| Secret | Used by | Purpose | +|---|---|---| +| `DOCKER_USERNAME` | `docker/login-action` | Registry authentication for image push | +| `DOCKER_PASSWORD` | `docker/login-action` | Registry authentication for image push | +| `KFORGE_NODE_IP` | kforge | Cluster node IP — written as the external-dns target annotation | + +`DOCKER_USERNAME` and `DOCKER_PASSWORD` are consumed by the Docker build steps in the generated workflow, not by kforge itself. `kforge validate` does not check for them. ### Category B — Gitea repo secrets